hw/arm/xlnx-versal-virt: modify gem/phy DT nodes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kay-ge
reviewed
Sep 17, 2024
|
@ho28 can you show some test results? Manual is fine. I'm not too familiar with what the CI tests test, but it looked like generic arm and generic x86 64. |
calvincramer
approved these changes
Sep 17, 2024
Modify the gem/phy device tree nodes so that VxWorks properly binds the genericPhy driver to the ethernet-phy DT node. Previously, the phy was represented using a fixed-link node that VxWorks does not parse properly. The compatible string for the gem node has been modified from "cdns,zynqmp-gem" to "cdns,versal-gem". The VxWorks gem driver does not match "cdns,zynqmp-gem". Note: VxWorks needs additional property "phy-mode" to properly bind the driver against "cdns,versal-gem". Signed-off-by: Nelson Ho <Nelson.Ho@windriver.com>
ho28
force-pushed
the
nho/versal/genericphy
branch
from
58a89e3
to
9f9f05a
Compare
|
I made the changes mentioned above, removed the unnecessary properties from the phy node. I also did some additional reading on the reg property of the phy node. I was under the assumption previously that the reg field (0xc) specified an offset from the regs or ranges presented by the GEM. After consulting the device tree documentation, it turns out the reg field is simply the phy index when specified as a property of a phy. I modified the constants and fields as appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the gem/phy device tree nodes so that VxWorks properly binds the genericPhy driver to the ethernet-phy DT node. Previously, the phy was represented using a fixed-link node that VxWorks does not parse properly.
The compatible string for the gem node has been modified from "cdns,zynqmp-gem" to "cdns,versal-gem". The VxWorks gem driver does not match "cdns,zynqmp-gem".
Note: VxWorks needs additional property "phy-mode" to properly bind the driver against "cdns,versal-gem".