Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OpenSSL's internal peer_name checking when verifyname is disabled. #239

Merged
merged 1 commit into from
Sep 16, 2016
Merged

Disable OpenSSL's internal peer_name checking when verifyname is disabled. #239

merged 1 commit into from
Sep 16, 2016

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Sep 9, 2016

Even with verify_peer disabled, OpensSSL will still perform peer_name checking, for example:

stream_socket_client(): Peer certificate CN=`dev.dd32.id.au' did not match expected CN=`test-vm'
stream_socket_client(): Failed to enable crypto
stream_socket_client(): unable to connect to ssl://test-vm:8443 (Unknown error)

@codecov-io
Copy link

Current coverage is 92.22% (diff: 0.00%)

Merging #239 into master will increase coverage by <.01%

@@             master       #239   diff @@
==========================================
  Files            21         21          
  Lines          1762       1763     +1   
  Methods         156        156          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1625       1626     +1   
  Misses          137        137          
  Partials          0          0          

Powered by Codecov. Last update fb5b517...b66d07a

@rmccue rmccue merged commit ea11b38 into WordPress:master Sep 16, 2016
@rmccue rmccue modified the milestones: 1.8, 1.7 Sep 16, 2016
@dd32 dd32 deleted the https-disable-peer_name-verification branch October 21, 2016 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants