Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Allow running the catalog and the API at the same time #145

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

sarayourfriend
Copy link
Contributor

Description

This fixes an issue where you could not run the API and the catalog at the same time due to conflicting postgres ports. This PR fixes the issue by changing the host port for the catalog postgres so that it no longer conflicts with the API postgres.

Tests

Checkout this branch and try running dc up -d for the catalog and the API together.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

This fixes the issue by changing the host port for the catalog
postgres so that it no longer conflicts with the API postgres.
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, and both projects can run at the same time in Docker locally.
Thank you for fixing this, @sarayourfriend !

Openverse automation moved this from Needs review to Reviewer approved Aug 19, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first Openverse PR!

@sarayourfriend sarayourfriend merged commit ea3b2b8 into main Aug 19, 2021
Openverse automation moved this from Reviewer approved to Done! Aug 19, 2021
@sarayourfriend sarayourfriend deleted the fix/make-harmonious-with-api branch August 19, 2021 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants