Science Museum: Handle unrecognized licenses

[AetherUnbound]

Fixes

Fixes WordPress/openverse#1580 by @AetherUnbound

Description

This PR addresses an issue wherein licenses which were expected to follow the CC license pattern actually ended up being generic license types. I have changed the tests to use in-line data, and added all of the cases I was able to capture that caused issues when I ran this locally.

I also added a new year range, 2020-2023, so we can include data from the last two years 😄

Testing Instructions

just test

If you want to observe the failure:

1. Check out main
2. Comment out all year ranges except (0, 1500) (this was the one that originally caused the error)
3. Disable your ingestion limit
4. Run the DAG, and note that the error in the issue occurs
5. Check out this branch
6. Ensure that the othe year ranges are still commented out
7. Run the DAG again, observe that it completes!

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[openverse-bot]

Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR:

@obulat
@stacimc
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend¹ days, this PR was updated 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)².

@AetherUnbound, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

1. Specifically, Saturday and Sunday. ↩

2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range. ↩

[obulat]

I tried running the script this way and checking the items without the license. They are either not openly-licensed, or not images. Great tests!

[krysal]

I was able to reproduce the error in main (quite fast!) as well, and the fix looks good 👍

[krysal]

Nice observation and addition! 💯