This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix homepage zooming on iPhone #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the input text to use `paragraph-large` (16px, line-height 190%) for widths less than `md`
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2160 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
obulat
added
🟥 priority: critical
|
Size Change: -4.17 kB (0%) Total Size: 894 kB
ℹ️ View Unchanged
|
dhruvkb
approved these changes
Feb 10, 2023
src/styles/tailwind.css
Outdated
Comment on lines
46
to
47
| Heading 5 - 19px - 3xl semibold | ||
| Heading 6 - 16px - 2xl semibold |
There was a problem hiding this comment.
Nit: 'semibold' is a valid word & the name of the corresponding Tailwind class.
There was a problem hiding this comment.
LGTM! I am still confused what I did different because I just couldn't get it to work, even with the large font size.
I wonder if the line height helped?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #2151 by @panchovm
Description
This PR sets the input text to use
paragraph-largestyle (16px, line-height 190%) for widths less thanmd.paragraph-largestyle was usingleading-larger, which was causing not-found errors during build. I replaced it withleading-[190%]. The line-height tailwind styles need to be fixed and will be fixed in later PRs.Also, WebStorm complains that
semiboldis incorrect, so I replaced it withsemi-bold:)Testing Instructions
Use iPhone and search for something from the homepage. You should not see the zooming as in the description of the linked issue.
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin