Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add a directive for translators to not translate Netherlands #2191

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Feb 15, 2023

Fixes

Fixes #2189 by @zackkrida

Description

Add a note for translators to not translate 'network', 'Netflix' and 'Netherlands', which are used as examples of words starting with 'net'. If translated to these would no longer be valid examples.

Alternative

An alternative approach would be to pick a different triplet of words in each language but that would be too cumbersome and wouldn't accurately reflect the English-centric nature of the Openverse search engine.

Testing Instructions

Test that the POT contains the comment.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added this to In progress in Openverse PRs Feb 15, 2023
@github-actions
Copy link

github-actions bot commented Feb 15, 2023

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/2191
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2191/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 📄 aspect: text Concerns the textual material in the repository labels Feb 15, 2023
@dhruvkb dhruvkb marked this pull request as ready for review February 15, 2023 19:32
@dhruvkb dhruvkb requested a review from a team as a code owner February 15, 2023 19:32
@openverse-bot openverse-bot moved this from In progress to Needs review in Openverse PRs Feb 15, 2023
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick, thanks!

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding the comment, why not to exclude those words for translations entirely and prevent that from happening?

@dhruvkb
Copy link
Member Author

dhruvkb commented Feb 16, 2023

@krysal do you mean by adding ESLint rules to ignore them and use raw text?

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked @krysal's suggestion at first, but then thought that if we ever add those words to the main site text, it would be affected, too. So, I prefer this fix instead.

Openverse PRs automation moved this from Needs review to Reviewer approved Feb 17, 2023
@dhruvkb dhruvkb merged commit 64df99a into main Feb 17, 2023
@dhruvkb dhruvkb deleted the netherlands_hint branch February 17, 2023 11:02
Openverse PRs automation moved this from Reviewer approved to Merged! Feb 17, 2023
github-actions bot pushed a commit that referenced this pull request Feb 17, 2023
@krysal
Copy link
Member

krysal commented Feb 17, 2023

Sorry for responding late. I wasn't thinking of excluding these words globally, just for the Search Help page. I send a PR with the fix in #2194.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text Concerns the textual material in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

Add translator note for Dutch translation of search-guide.example.prefix.content
5 participants