Blueprints: Write sunrise.php to /internal in enableMultisite step #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elated to redefining those constants Changes the default meethod of defining PHP constants from rewriting the `define()` calls in wp-config.php to pre-defining constants via an `auto_prepend_file`. ## Problem solved by this PR Playground needs to define some WordPress constants like SITE_URL or HOME_URL. Unfortunately, the site loaded into Playground may already have a conflicting `define()` call in its `wp-config.php`. Historically, we'va avoided PHP warnings by rewriting the `define()` calls in the `wp-config.php` file. It works quite well, but when the `wp-config.php` file is mounted from a local directory, Playground would change its contents. This is typically not what the user wants. These changes would show up in `git commit` and would be annoying at best, or get accidentally commited to the repository at worst. ## Implementation Instead of rewriting the `wp-config.php`, this PR changes the default behavior to defining the constants in a pre-loaded PHP file. This triggers PHP warnings, but we're silencing them using a custom error handler. As a result, Playground constants take precedence over custom define() calls in a way that doesn't trigger warnings. This is an easy and hacky way of implementing this. A better solution would be a PHP.wasm-level patch to enable "warning-less constants" that can't be redefined but the conflicting `define()` call fails silently. ## Testing instructions Confirm the unit tests pass
adamziel
added
[Type] Enhancement
|
The test failure is intermittent, let's merge |
adamziel
added a commit
that referenced
this pull request
May 15, 2024
Prevents creating a `wp-config.php` file in WordPress document root. Instead, creates it one level higher as WordPress falls back to loading it from there. Related to #1398. Similar to #1382 and #1401. ## Testing instructions Run `bun packages/playground/cli/src/cli.ts server --login` and confirm it loads an installed WordPress.
adamziel
added a commit
that referenced
this pull request
May 15, 2024
Prevents creating a `wp-config.php` file in WordPress document root. Instead, creates it one level higher as WordPress falls back to loading it from there. Related to #1398. Similar to #1382 and #1401. ## Testing instructions Run `bun packages/playground/cli/src/cli.ts server --login` and confirm it loads an installed WordPress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Writes sunrise.php to the
/internaldirectory instead of/wordpressto ensure setting up a multisite won't pollute local website when mounted.Related to Boot Protocol
Testing Instructions
Confirm the CI checks pass.