Expose grid text and additional constellation settings #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the ability to toggle the grid text for the four grids that are exposed (equatorial, ecliptic, alt/az, and galactic), as well as the ability to toggle constellation labels and pictures. One intended use case is
glue-wwt
(i.e. as an extension to what's currently in glue-viz/glue-wwt#97).The implementation for some of these properties already existed but were commented out. There are some notes about the constellation properties in the commit where they were commented out here. In my testing both of these properties work fine (and I don't see any errors coming up while scrolling with the constellation pictures enabled), so my suspicion is that these comments relate to an older (pre-research app) pywwt implementation. Regardless, all of these properties work fine in my local testing.
I decided to name the member value corresponding to the equatorial grid text as just
grid_text
for consistency with thegrid
member value. It's worth noting that the text for a grid won't draw unless the grid is displayed - i.e. the value ofalt_az_text
has no effect unlessalt_az_grid
isTrue
. This is consistent with the internal engine settings.If we're okay with the implementation here, I'll update the image testing to take these settings into account.