Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the engine and more sponsorship branding changes #366

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

pkgw
Copy link
Contributor

@pkgw pkgw commented Sep 15, 2023

Overview

One thing we do here is update to the latest release of the research app, which depends on the new ESM-based version of the WebGL engine. The ESM transition shouldn't affect anything besides the experience of developing the engine itself, but it will be good to bring it in to flush out any potential problems caused by the switchover.

We also update more sponsorship branding stuff in the README and around the codebase.

Finally, there are some updates to the Python build system to try to remove some warnings and improve the source distribution tarball.

Checklist

  • [N/A] Changed code has some test coverage (or justify why not)
  • [N/A] Changes in functionality documented (or justify why not)

This will help us smoke out any issues associated with the transition
to the new build system, although hopefully there won't be any.
This should hopefully fix up some warnings and improve the contents of
the sdist tarball -- we were including `docs/_build`.
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #366 (a402864) into master (7106a7f) will not change coverage.
The diff coverage is n/a.

❗ Current head a402864 differs from pull request most recent head 4c326f5. Consider uploading reports for the commit 4c326f5 to get more accurate results

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   56.51%   56.51%           
=======================================
  Files          25       25           
  Lines        2870     2870           
=======================================
  Hits         1622     1622           
  Misses       1248     1248           
Files Changed Coverage Δ
pywwt/jupyter.py 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pkgw pkgw merged commit 6c5bae2 into WorldWideTelescope:master Sep 15, 2023
3 checks passed
@pkgw pkgw deleted the engine-and-branding branch September 15, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant