Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixups for Numpy 2 compatibility #377

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

pkgw
Copy link
Contributor

@pkgw pkgw commented Jun 25, 2024

Overview

Try to make sure we work with Numpy 2!

Checklist

  • Changed code has some test coverage (or justify why not)
  • [N/A] Changes in functionality documented (or justify why not)

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.40%. Comparing base (8fcaff9) to head (d8800e9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   56.51%   56.40%   -0.11%     
==========================================
  Files          25       25              
  Lines        2872     2863       -9     
==========================================
- Hits         1623     1615       -8     
+ Misses       1249     1248       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pkgw
Copy link
Contributor Author

pkgw commented Jun 25, 2024

This one change appears to be all that we need!

@pkgw pkgw merged commit f20f1f4 into WorldWideTelescope:master Jun 25, 2024
4 of 5 checks passed
@pkgw pkgw deleted the numpy2 branch June 25, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant