Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Straxify strax interface #299

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

jmosbacher
Copy link
Member

What is the problem / what does the code in this PR do
Strax interface plugin implements its own configuration management, bypassing the strax config management. This results in many hacks and unneeded complexity when generating the strax context. I assume this was done because of the large number of config options and their historical loading from config files.
The overlapping of config names between fax configuration and straxen processing plugins (for obvious reasons) creates two main issues:

  1. Changing fax config values wont change the raw data hash, requiring the creation of "simulation run ids" to define different fax settings.
  2. Having divergent configuration for waveform generation and processing is difficult and requires hacks that depend on straxen internals which may change and break everything.

This PR is an experiment on whether we can use strax config management for all fax configs and remove the set_config() method.

The implementation is still a work in progress, it may take some time to get a working prototype.

@JoranAngevaare JoranAngevaare marked this pull request as ready for review June 9, 2022 12:32
@JoranAngevaare JoranAngevaare marked this pull request as draft June 9, 2022 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants