review optional

XavierM · Aug 28, 2019 · 82ac8bd · 82ac8bd
1 parent 0b75440
commit 82ac8bd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/x-pack/legacy/plugins/siem/public/store/timeline/types.ts b/x-pack/legacy/plugins/siem/public/store/timeline/types.ts
@@ -26,7 +26,6 @@ export interface TimelineState {
 }
 
 export interface ActionTimeline extends Action<string> {
-  type: string;
   payload: {
     id: string;
     eventId: string;

diff --git a/x-pack/legacy/plugins/siem/server/lib/pinned_event/saved_object.ts b/x-pack/legacy/plugins/siem/server/lib/pinned_event/saved_object.ts
@@ -152,6 +152,10 @@ export class PinnedEvent {
       return null;
     } catch (err) {
       if (getOr(null, 'output.statusCode', err) === 404) {
+        /*
+         * Why we are doing that, because if it is not found for sure that it will be unpinned
+         * There is no need to bring back this error since we can assume that it is unpinned
+         */
         return null;
       }
       if (getOr(null, 'output.statusCode', err) === 403) {