Merge upstream #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply_object returns only the patch - we need to actually apply the patch to the existing object. Fixes ansible/ansible#66780
The meta data field is deprecated and is not used anymore. See ansible-collections/overview#57 for more details.
Remove ANSIBLE_METADATA
…deprecated Fixes ansible-collections#96: Sanity test finds incorrect deprecated usage.
…-added Add version_added to docs for each of the new collection modules.
Ensure that Deployments and Daemonsets properly await all replicas to be available. Correctly handles the subtle edge case when a service account no longer exists. Note that this will dramatically slow Daemonset updates
…heck_mode_fix K8s apply check mode fix
Coverage improvement for the project is not a requirement of the collections projects. Don't fail builds on coverage reduction
…erage_failure_check Don't run project coverage on patches
…ions Make deployments and daemonsets wait for pods to be ready
Documenting the structure of the dictionary to pass in needs to be done via suboptions rather than putting the structure directoly inside of the toplevel option.
Fails using 0.11.0
Fix the docs for the inventory plugins.
…d_dict Add test for openshift apply bug
Move wait logic out of raw and into common and use that logic in scale Fix a few broken wait condition cases highlighted by scaling up and down Move scale-related tests into dedicated test task file Additional service related tests
See https://github.com/engineerd/setup-kind/releases/tag/v0.4.0 for details of the EXDEV issue
Move wait logic out of raw and into common and use that logic in scale Fix a few broken wait condition cases highlighted by scaling up and down Move scale-related tests into dedicated test task file Additional service related tests
…ovements k8s_scale fixes
…ions#107) * Keep backwards compatibility with playbooks using community.kubernetes content with module_defaults groups
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Inventory plugin example should read 'api_key' instead of 'token' Fixes: ansible-collections#101 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
helm: minor code refactoring
* Spelling fixes * Documentation update * Example update to use FQCN Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
api_groups is returned as "dict_keys()" which k8s lookip plugin does not handle. Typecasting with list make it available to default callback plugin.
Use information from strategic merges to improve the quality of diffs, particularly for list items (order no longer important, and adding/removing an item from a list just shows that item in the diff, not the whole list)
Partially fix ansible-collections#36 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
…mpt-labels PR ansible-collections#196 follow-up: Adjust stale bot exemptLabels.
…m_build add Makefile and downstream build script
…t_connection_plugin Set the connection plugin and transport separately, add tests
…dules Signed-off-by: Adam Miller <admiller@redhat.com>
…sanity_tests fix CI tests, helm picked up the same argspec addition as some k8s mo…
Signed-off-by: Adam Miller <admiller@redhat.com>
…m/fix_ci_round_2 fix downstream ci names (round 2)
kubectl exec is printed twice in the console log. Fixes: ansible-collections#200 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
…sible-collections#213) Signed-off-by: Adam Miller <admiller@redhat.com>
Fixes: ansible-collections#106 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Moved a bunch of common things to module_utils.
When the diff contains changes only to the fields `metadata.generation` or `metadata.resourceVersion`, do not mark the task as changed. Instead, emit a warning highlighting that the API itself may not be idempotent, but that there was no meaningful difference between the desired and actual state of the resource.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
handle exception raised due to DynamicClient
…fig_fix helm: Support vaulted kubeconfig
…with-warning Do not mark task as changed when diff is irrelevant
…ctions#227) * Make an AnsibleMixin parent class for every module * Replace KubernetesAnsibleModule class with dummy class * Modified k8s_log * k8s_exec refactor * k8s_info refactor * k8s_service refactor * k8s_scale refactor * Fix integration tests * Add a warning about the deprecation of KubernetesAnsibleModule * Add a dummy class for backward compatibility Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.