expression: implement vectorized evaluation for 'builtinCastJSONAsJSO…

…NSig' (pingcap#12794)
XiaTianliang · Dec 21, 2019 · a4ce627 · a4ce627
1 parent 029faf0
commit a4ce627
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/expression/builtin_cast_vec.go b/expression/builtin_cast_vec.go
@@ -582,11 +582,11 @@ func (b *builtinCastIntAsJSONSig) vecEvalJSON(input *chunk.Chunk, result *chunk.
 }
 
 func (b *builtinCastJSONAsJSONSig) vectorized() bool {
-	return false
+	return true
 }
 
 func (b *builtinCastJSONAsJSONSig) vecEvalJSON(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
+	return b.args[0].VecEvalJSON(b.ctx, input, result)
 }
 
 func (b *builtinCastJSONAsStringSig) vectorized() bool {

diff --git a/expression/builtin_cast_vec_test.go b/expression/builtin_cast_vec_test.go
@@ -50,6 +50,7 @@ var vecBuiltinCastCases = map[string][]vecExprBenchCase{
 		{retEvalType: types.ETDuration, childrenTypes: []types.EvalType{types.ETDuration}},
 		{retEvalType: types.ETJson, childrenTypes: []types.EvalType{types.ETInt}},
 		{retEvalType: types.ETJson, childrenTypes: []types.EvalType{types.ETReal}},
+		{retEvalType: types.ETJson, childrenTypes: []types.EvalType{types.ETJson}},
 	},
 }