updating make flow to support new image structure #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterOgden
reviewed
Jan 16, 2017
| @@ -163,13 +162,12 @@ doc_notebooks: | |||
| ${FINAL_NOTEBOOKS_DIR}/getting_started/2_programming_python.ipynb | |||
| cp ${REPO_DIR}/docs/source/5_programming_onboard.ipynb \ | |||
| ${FINAL_NOTEBOOKS_DIR}/getting_started/3_programming_onboard.ipynb | |||
| cp ${REPO_DIR}/docs/source/6a_base_overlay_iop.ipynb \ | |||
There was a problem hiding this comment.
Are these changes correct? The file names haven't changed in the repo yet.
There was a problem hiding this comment.
I see these are the source file names in the image_2017_01 branch ... let me know if breaking update flow.
There was a problem hiding this comment.
Sorry Graham, must have misread the branch I was on. Rest of the change looks good to me,
yunqu
pushed a commit
to yunqu/PYNQ
that referenced
this pull request
Jan 23, 2017
schelleg
added a commit
to schelleg/PYNQ
that referenced
this pull request
Feb 16, 2017
schelleg
added a commit
to schelleg/PYNQ
that referenced
this pull request
Feb 16, 2017
schelleg
added a commit
to schelleg/PYNQ
that referenced
this pull request
Feb 16, 2017
schelleg
added a commit
to schelleg/PYNQ
that referenced
this pull request
Feb 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.