Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More consistent positioning of fullscreen windows #274

Merged
merged 1 commit into from
Dec 21, 2023
Merged

More consistent positioning of fullscreen windows #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion html5/js/Client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3325,7 +3325,7 @@ class XpraClient {
}
let client_properties = {};
if (packet.length >= 8) client_properties = packet[7];
if (x == 0 && y == 0 && !metadata["set-initial-position"]) {
if (x == 0 && y == 0 && !metadata["set-initial-position"] && !metadata["fullscreen"]) {
//find a good position for it
const l = Object.keys(this.id_to_window).length;
if (l == 0) {
Expand Down
6 changes: 4 additions & 2 deletions html5/js/Window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,19 +124,21 @@ class XpraWindow {
jQuery(this.div).addClass(`window-${this.windowtype}`);
}

const fullscreen = (metadata["fullscreen"]) ?? false;

if (this.client.server_is_desktop || this.client.server_is_shadow) {
jQuery(this.div).addClass("desktop");
this.resizable = false;
} else if (this.tray) {
jQuery(this.div).addClass("tray");
} else if (this.override_redirect) {
jQuery(this.div).addClass("override-redirect");
} else if (
} else if (!fullscreen && (
this.windowtype == "" ||
this.windowtype == "NORMAL" ||
this.windowtype == "DIALOG" ||
this.windowtype == "UTILITY"
) {
)) {
this.resizable = true;
}

Expand Down
Loading