Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obfuscate passwords from the command line #3196

Closed
totaam opened this issue Jul 10, 2021 · 1 comment
Closed

obfuscate passwords from the command line #3196

totaam opened this issue Jul 10, 2021 · 1 comment
Labels
enhancement New feature or request network

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 10, 2021

Running:

xpra attach ssh://USERNAME:PASSWORD@HOSTNAME/

Shows the password in the process list.
We should detect that a password is present in the sys.args during parsing and flag it so that the clients can then obfuscate it.

@totaam totaam added enhancement New feature or request network labels Jul 10, 2021
totaam added a commit that referenced this issue Jul 13, 2021
totaam added a commit to Xpra-org/gtk-osx-build that referenced this issue Jul 13, 2021
@totaam
Copy link
Collaborator Author

totaam commented Jul 13, 2021

This will do.
But don't rely on it

Important caveats for anyone reading this:

  • we can't hide the password until we get to the point where we are using the command line arguments, which may several seconds or more after the command is executed - anyone reading the process list during that time will still be able to see the password
  • not all commands are being obfuscated - check if the one you are using is one of those

@totaam totaam closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request network
Projects
None yet
Development

No branches or pull requests

1 participant