feat: allow create SAS token for azure storage #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godruoyi
commented
May 5, 2023
godruoyi
commented
May 5, 2023
Xuanwo
reviewed
May 5, 2023
godruoyi
commented
May 5, 2023
Xuanwo
reviewed
May 5, 2023
godruoyi
commented
May 8, 2023
Comment on lines
+139
to
+145
| pub fn sign_query( | ||
| &self, | ||
| req: &mut impl SignableRequest, | ||
| expire: Duration, | ||
| cred: &Credential, | ||
| ) -> Result<()> { | ||
| let ctx = self.build(req, SigningMethod::Query(expire), cred)?; |
There was a problem hiding this comment.
@Xuanwo Please note that we have modified the signature of this function, and we need to pay attention to compatibility when releasing the version.
There was a problem hiding this comment.
Thanks! We should release v0.10 instead!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #301
This PR is support azure SAS token(account SAS), we will try to generate SAS token when call
sign_querywithout settingSharedAccessSignature(token)in Credential.