Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): API Version should be specified by clients #334

Merged
merged 2 commits into from
May 31, 2023

Conversation

Xuanwo
Copy link
Owner

@Xuanwo Xuanwo commented May 31, 2023

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit aa28ce2 into main May 31, 2023
@Xuanwo Xuanwo deleted the add-version-support-for-azblob branch May 31, 2023 03:50
@sunng87
Copy link

sunng87 commented May 31, 2023

hey @Xuanwo , this breaks opendal azure backend:

443 |         let batch_signer = AzureStorageSigner::new().omit_service_version();
    |                                                      ^^^^^^^^^^^^^^^^^^^^ method not found in `AzureStorageSigner`

You might want to release this in a minor version bump

@Xuanwo
Copy link
Owner Author

Xuanwo commented May 31, 2023

Oh, you are right.

@Xuanwo
Copy link
Owner Author

Xuanwo commented May 31, 2023

I will yank this version first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants