[wenhao] increase unit test coverage.

XvJ96 · Oct 15, 2019 · 4ee4577 · 4ee4577
1 parent 0b170f6
commit 4ee4577
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 15 deletions.
diff --git a/config/githooks/commit-msg b/config/githooks/commit-msg
@@ -1,19 +1,13 @@
 #!/usr/bin/env bash
 
-# Color codes
-red='\033[0;31m'
-yellow='\033[0;33m'
-blue='\033[0;34m'
-NC='\033[0m' # No colors
-
 # Regex & Usage
 commit_regex="^(\[\S+(\s\&\s\S+)*\]|merge)\s"
 error_message="Aborting commit. Commit message must start with [YOUR NAME]."
 usage="[YOUR NAME] Commit Message."
 
 if ! grep -qE "$commit_regex" "$1"; then
-  printf "${red}$error_message\n"
-  printf "${yellow}Commit Regex: ${NC}${commit_regex}\n"
-  printf "${red}Usage: ${NC}${usage}\n"
+  printf "error_message\n"
+  printf "Commit Regex: ${commit_regex}\n"
+  printf "Usage: ${usage}\n"
   exit 1
 fi
diff --git a/config/githooks/pre-push b/config/githooks/pre-push
@@ -1,14 +1,10 @@
 #!/usr/bin/env bash
 
-# Color codes
-red='\033[0;31m'
-yellow='\033[0;33m'
-
 command="./gradlew build"
 
 ${command}
 
 if ! [ $? -eq 0 ]; then
-    printf "${red}Make sure successfully execute command: ${yellow}$command${red}."
+    printf "Make sure successfully execute command: $command."
     exit 1
 fi
diff --git a/src/test/java/com/github/wenhao/jpa/integration/InTest.java b/src/test/java/com/github/wenhao/jpa/integration/InTest.java
@@ -46,10 +46,12 @@ public void should_be_able_to_find_by_using_in() {
         // given
         Person jack = new PersonBuilder()
                 .name("Jack")
+                .nickName("Jack")
                 .age(18)
                 .build();
         Person eric = new PersonBuilder()
                 .name("Eric")
+                .nickName("Eric")
                 .age(20)
                 .build();
         personRepository.save(jack);
@@ -58,6 +60,7 @@ public void should_be_able_to_find_by_using_in() {
         // when
         Specification<Person> specification = Specifications.<Person>and()
                 .in(isNotBlank(jack.getName()), "name", Arrays.asList("Jack", "Eric"))
+                .in("name", Arrays.asList("Jack", "Eric"))
                 .build();
 
         List<Person> persons = personRepository.findAll(specification);

diff --git a/src/test/java/com/github/wenhao/jpa/integration/NotInTest.java b/src/test/java/com/github/wenhao/jpa/integration/NotInTest.java
@@ -46,10 +46,12 @@ public void should_be_able_to_find_by_using_in() {
         // given
         Person jack = new PersonBuilder()
                 .name("Jack")
+                .nickName("Jack")
                 .age(18)
                 .build();
         Person eric = new PersonBuilder()
                 .name("Eric")
+                .nickName("Eric")
                 .age(20)
                 .build();
         personRepository.save(jack);
@@ -58,6 +60,7 @@ public void should_be_able_to_find_by_using_in() {
         // when
         Specification<Person> specification = Specifications.<Person>and()
                 .notIn(isNotBlank(jack.getName()), "name", Arrays.asList("Eric"))
+                .notIn("nickName", Arrays.asList("Eric"))
                 .build();
 
         List<Person> persons = personRepository.findAll(specification);

diff --git a/src/test/java/com/github/wenhao/jpa/integration/NotLikeTest.java b/src/test/java/com/github/wenhao/jpa/integration/NotLikeTest.java
@@ -59,7 +59,7 @@ public void should_be_able_to_find_by_using_not_like() {
         // when
         Specification<Person> specification = Specifications.<Person>and()
                 .notLike(isNotBlank(jack.getName()), "name", "%ac%")
-                .notLike(isNotBlank(jack.getNickName()), "name", "%og%", "%ri%")
+                .notLike("name", "%og%", "%ri%")
                 .build();
 
         List<Person> persons = personRepository.findAll(specification);