-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/non native #396
Feature/non native #396
Conversation
Added Slovak strings
Added Dutch strings
Added dutch translation
Added Dutch translation
Merge from origin
Add zh-tw strings
… allow empty toolbar title
Add ability to customize toolbar drawables, root background color and allow empty toolbar title
Add methods in UCrop for getting the image width + height
maxSdkVersion removed - needed for saving image to Downloads
Made cropCIMG static
add FR translation file
…agePermission M permissions removed: not mandatory
…utside, and then inside again would make the crop rect jump. Reset previous touch points.
Fix: In freestyle crop, where user tap inside of the crop rect then o…
When a square image is rotated by 90 (180, 270) degrees, it is not croped.
Feature: Add a new freestyle crop mode.
When a square image is rotated by 90 (180, 270) degrees, it is not croped.
…Translation Feature/german translation
Hotfix/GitHub issue
fix Markdown formatting
Conflicts: build.gradle gradle/wrapper/gradle-wrapper.properties sample/build.gradle ucrop/build.gradle ucrop/src/main/java/com/yalantis/ucrop/task/BitmapCropTask.java
if (uri != null) { | ||
try { | ||
UCropView uCropView = findViewById(R.id.ucrop); | ||
uCropView.getCropImageView().setImageUri(getIntent().getData(), null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reuse uri variable
.getSystemService(Context.NOTIFICATION_SERVICE); | ||
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||
int importance = NotificationManager.IMPORTANCE_LOW; | ||
NotificationChannel mChannel = new NotificationChannel(CHANNEL_ID, getString(R.string.channel_name), importance); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mChannel is not a field. I recommend to move creation of channel into separate method
public static UCropFragment newInstance(Bundle uCrop, UCropFragmentCallback callback) { | ||
UCropFragment fragment = new UCropFragment(); | ||
fragment.setArguments(uCrop); | ||
fragment.setCallback(callback); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remake setting callback via onAttach method
The same for non native