Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

Don't add misleading red bar to the thumbnail of videos without likes/dislikes #1195

Closed
mzso opened this issue Nov 25, 2014 · 7 comments
Closed
Milestone

Comments

@mzso
Copy link

mzso commented Nov 25, 2014

Hello!
It's a small annoyance but sometimes it can mislead me to think that a video's garbage even when it isn't

@YePpHa YePpHa added this to the 2.1.7 milestone Nov 25, 2014
@YePpHa
Copy link
Owner

YePpHa commented Nov 25, 2014

I will add an option to give the sparkbar a default color if there are no likes or dislikes.

@mzso
Copy link
Author

mzso commented Nov 25, 2014

Cool.

@YePpHa YePpHa closed this as completed in 341c954 Nov 25, 2014
@mzso
Copy link
Author

mzso commented Nov 25, 2014

Something's not right. I see the default color in the settings. But still a red bar shows up for videos without ratings. Also under the suggestion thumbnails I get red bars for those that should be all green. (They're properly green on the search page.)

@YePpHa
Copy link
Owner

YePpHa commented Nov 25, 2014

I will look into this.

@YePpHa
Copy link
Owner

YePpHa commented Nov 25, 2014

Hmm. weird I just tested it and it worked for me.

Here an example of one of my tests (changed the colors to test if they worked). The last one with the green bar has 0 likes and 0 dislikes.
ss 2014-11-25 at 09 01 38

And my settings are as follows:
ss 2014-11-25 at 09 02 03

@mzso
Copy link
Author

mzso commented Nov 25, 2014

My bad. Sorry. I had some CSS script lying around I totally forgot about.
There seem to be some issues though. This is from a mostly empty profile with nothing else youtube related enabled (9px height):
ytc-r
And this is from my main profile(2px):
ytc-rating

(PS: an RGB 0-255 option for the colors would be nice. I can't really tell with hex how large the number is.)

@YePpHa
Copy link
Owner

YePpHa commented Nov 25, 2014

I might add RGB to the color picker at some time.

YePpHa added a commit that referenced this issue Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants