Challenges 1-4 in Java #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public static void invert(Node root) { | ||
|
|
||
| // Stop at the n-1 row |
There was a problem hiding this comment.
You probably want to invert if it's got at least one child. The child could be the root of a full tree.
| * | ||
| * @author zmiller | ||
| */ | ||
| public class Queue<T> { |
There was a problem hiding this comment.
Why write this wrapper when this already exists in the Java standrd libs?
There was a problem hiding this comment.
There's no reason.
…rt no longer stops at the second to last row, it does a complete DFS now.
|
Remillardj
reviewed
Jan 3, 2017
There was a problem hiding this comment.
theres a ton of comments. I bet most of those would be helpful in the readme instead of source. Try to make your code so concise and obvious that it doesnt need comments. Other than that, I like your use of the while loop and isEmpty() in line 50 of challenge_4/InvertBinaryTree.java
|
bypass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.