[python]challenge_[6](Pending) #225
Conversation
| import unittest | ||
| import time | ||
| from Solution import solution | ||
|
|
There was a problem hiding this comment.
Is this much whitespace typical in Python? I would assume 1 newline would suffice. Thoughts on removing the extra newlines.
| @@ -0,0 +1,28 @@ | |||
| # Writing solution for this range problem | |||
|
|
|||
| class solution(object): | |||
There was a problem hiding this comment.
Can this just be class Solution:?
There was a problem hiding this comment.
I suppose, but I don't think that's a big deal.
| # Writing solution for this range problem | ||
|
|
||
| class solution(object): | ||
| def compRange(self,nums): |
There was a problem hiding this comment.
I believe the PEP 8 styleguide wants a space after commas.
There was a problem hiding this comment.
I didn't know what PEP was until I read this comment.
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| unittest.main() |
| t1 = time.time() | ||
| out = case1.compRange(tlist) | ||
| t2 = time.time() | ||
| print "Runtime for case1: " + str(t2-t1) + " seconds" |
There was a problem hiding this comment.
I believe the pep 8 styleguide implies that spaces should go around all binary operators like " - " and " % "
| # Writing solution for this range problem | ||
|
|
||
| class solution(object): | ||
| def compRange(self,nums): |
There was a problem hiding this comment.
I didn't know what PEP was until I read this comment.
| @@ -0,0 +1,28 @@ | |||
| # Writing solution for this range problem | |||
|
|
|||
| class solution(object): | |||
There was a problem hiding this comment.
I suppose, but I don't think that's a big deal.
MJUIUC
changed the title
Here's my Solution for challenge 6.