Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Challenge 5 (Pending) #359

Merged
merged 3 commits into from
Jan 23, 2017
Merged

[Python] Challenge 5 (Pending) #359

merged 3 commits into from
Jan 23, 2017

Conversation

sarcodian
Copy link
Contributor

No description provided.

karanchawla
karanchawla requested changes Jan 11, 2017
View reviewed changes
Copy link
Collaborator

@karanchawla karanchawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation

@ning-y
Copy link
Contributor

ning-y commented Jan 12, 2017 •
edited
Loading

  • Code Correctness
  • Code Style
  • Code Documentation
    Good enough for me ¯\_(ツ)_/¯
    Try to document a thought process or programming logic next time though
  • Path Structure
  • Merge Pull Request
  1. Your README.md looks to be the actual challenge documentation (i.e. the question), not a documentation of your solution.
  2. Your solution works! Consider though, using the in-built collections library next time.

@sarcodian
Copy link
Contributor Author

Added documentation

@ning-y
Copy link
Contributor

ning-y commented Jan 16, 2017

@sarcodian You're good to go, change the 'Unreviewed' in parenthesis in your PR title to 'Pending'.

@sarcodian sarcodian changed the title [Python] Challenge 5 (Unreviewed) [Python] Challenge 5 (Pending) Jan 17, 2017
@slandau3 slandau3 merged commit 0009821 into YearOfProgramming:master Jan 23, 2017
@sarcodian sarcodian deleted the python_5 branch January 23, 2017 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanchawla karanchawla karanchawla requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sarcodian @ning-y @karanchawla @slandau3