Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Challenge 10 (Unreviewed) #364

Merged
merged 5 commits into from
Jan 23, 2017
Merged

[Python] Challenge 10 (Unreviewed) #364

merged 5 commits into from
Jan 23, 2017

Conversation

sarcodian
Copy link
Contributor

No description provided.

@karanchawla
Copy link
Collaborator

You haven't considered '<' and '>' in your method. Also add documentation for your function definition.

@sarcodian
Copy link
Contributor Author

sarcodian commented Jan 11, 2017 •
edited
Loading

The < and > weren't in the original spec and as such are ignored like other char's. Will add a function definition.

slandau3
slandau3 requested changes Jan 11, 2017
View reviewed changes
Copy link
Collaborator

@slandau3 slandau3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation and I'll merge it.

@slandau3 slandau3 merged commit 69725c0 into YearOfProgramming:master Jan 23, 2017
@sarcodian sarcodian deleted the python_10 branch January 23, 2017 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slandau3 slandau3 slandau3 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sarcodian @karanchawla @slandau3