Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp] Challenge 2 (Pending) #450

Merged
merged 9 commits into from
Jan 24, 2017
Merged

[cpp] Challenge 2 (Pending) #450

merged 9 commits into from
Jan 24, 2017

Conversation

dewie102
Copy link
Contributor

No description provided.

Copy link

@moonpatroller moonpatroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [ok] Code Correctness
  • [ok] Code Style
  • [ok] Code Documentation
  • [ok] Path Structure
  • [idk] Merge Pull Request

Copy link
Collaborator

@karanchawla karanchawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Check out the section of branching your main branch - so that your PRs have separate challenges and they don't get merged in a single PR.

@@ -0,0 +1,21 @@
# Reverse a String
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This challenge is called Single Number.

Copy link
Contributor Author

@dewie102 dewie102 Jan 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I copied over the file to get the layout and forgot to change it, thank you for pointing that out.

@dewie102
Copy link
Contributor Author

Also for branching I made the mistake of merging my challenge branch into my master instead of onto the yearofprogramming repository, I am trying to fix it as I go.

@dewie102 dewie102 changed the title [cpp] Challenge 2 (Unreviewed) [cpp] Challenge 2 (Pending) Jan 24, 2017
@erocs erocs merged commit 1835649 into YearOfProgramming:master Jan 24, 2017
@dewie102 dewie102 deleted the cpp_2 branch January 25, 2017 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants