Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split test strings into a dictionary #161

Merged
merged 6 commits into from
Apr 11, 2019
Merged

Conversation

baboateng
Copy link
Contributor

with the current dict minus is a little confusing. Each time you add one example, you need to remember to edit them in multiple places. Also the minus from STANDARD_POSITIVES is using a dict, while the plus on STANDARD_NEGATIVES is using a list. This is inconsistent and confusing.

This PR breaks the STANDARD_POSITIVES and STANDARD_NEGATIVES into dicts list and for each test case, concat them together to form the required fixture list.

@KevinHock KevinHock self-requested a review April 11, 2019 18:05
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, I really appreciate you improving my code! ❤️ This is better

@KevinHock KevinHock merged commit c46a1b6 into Yelp:master Apr 11, 2019
@baboateng baboateng deleted the cleanupTest branch April 11, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants