-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearer usage commands #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does --help
look like? (i.e. the usage message.)
@@ -194,6 +230,11 @@ def consolidate_args(args): | |||
|
|||
:param args: output of `argparse.ArgumentParser.parse_args` | |||
""" | |||
# Using `--hex-limit` as a canary to identify whether this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This seems a little hacky.
# Favors --import argument over stdin. | ||
if getattr(args, 'import'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Much better :D
|
Random: What is your opinion on adding that to the README? To much/ugly or helpful? e.g. https://github.com/python-security/pyt#usage |
I've seen it some places; no real preference. I figure, examples to get going are better, and if people want the "advanced" options, they can read The README needs to be updated with this API change, but I'll do that with the version bump. |
Previously, scanning and auditing were command line flags. This meant that technically, they could be used in the following manner:
which doesn't really make any sense.
This change clarifies the API a little, so we avoid this situation.