Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

P2 877 fix jobs html #1178

Merged
merged 10 commits into from
May 11, 2021
Merged

P2 877 fix jobs html #1178

merged 10 commits into from
May 11, 2021

Conversation

andizer
Copy link
Contributor

@andizer andizer commented Apr 28, 2021

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/schema-blocks] Provides a way to set the tagName that is used to render the value in the select instruction.
  • [@yoast/schema-blocks] Removes the div as wrapping element of the value that is set in the date instruction.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    *

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@andizer andizer added innovation changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog labels Apr 28, 2021
@andizer andizer added this to the 16.3 milestone Apr 28, 2021
Copy link
Contributor

@hansjovis hansjovis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 👍

I did refactor the TagName a bit, I could not help myself.

Plus I removed an extra whitespace within a method call in a test.

(See the last two commits)

@johannadevos johannadevos changed the base branch from release/16.3 to develop April 30, 2021 08:55
@johannadevos johannadevos modified the milestones: 16.3, 16.4 Apr 30, 2021
@johannadevos
Copy link
Contributor

Acceptance: ✅ (see Yoast/wordpress-seo-premium#3297)

@johannadevos johannadevos merged commit bbb9e82 into develop May 11, 2021
@johannadevos johannadevos deleted the P2-877-fix-jobs-html branch May 11, 2021 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog innovation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants