This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andizer
added
innovation
changelog: enhancement
Needs to be included in the 'Enhancements' category in the changelog
labels
Apr 28, 2021
hansjovis
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: 👍
I did refactor the TagName
a bit, I could not help myself.
Plus I removed an extra whitespace within a method call in a test.
(See the last two commits)
…-877-fix-jobs-html
…-877-fix-jobs-html
…-877-fix-jobs-html
…-877-fix-jobs-html
Acceptance: ✅ (see Yoast/wordpress-seo-premium#3297) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
changelog: enhancement
Needs to be included in the 'Enhancements' category in the changelog
innovation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
tagName
that is used to render the value in the select instruction.div
as wrapping element of the value that is set in the date instruction.Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Impact check
*
UI changes
Quality assurance
Fixes #