Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Liberty parser to make it more permissive of paranthetical expressions and keeper cells #2503

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jrrk2
Copy link

@jrrk2 jrrk2 commented Dec 24, 2020

Dear Clifford,
Keep up the good work with yosys. here is my humble contribution to the liberty parser improvement. I could understand it being done in a better way, however. The improvements are:

  1. Explicitly skipping keeper cells
  2. accepting state_function as a keyword as well as function (in flip-flops)
  3. handling internal pins in a different way
  4. handling paranthetical expressions after a keyword colon sequence

Copy link
Member

@clairexen clairexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indenting of this is all messed up (spaces instead of blanks) and doesn't follow the CodyingStyle document (it looks like GNU coding style). Please update to use the proper indenting and coding style to match the surrounding code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants