Add support for subtract in preadder #3459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gs-jgj
force-pushed
the
feature_dsp48e1_presub
branch
from
f9dc0fe
to
ab6eba7
Compare
gs-jgj
force-pushed
the
feature_dsp48e1_presub
branch
from
ab6eba7
to
2949e5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired in part by how it is done for xilinx_dsp48a
The width check of 30 bits is kept for port A, but I wasn't able to create any cases where it really made sense (for cascading, etc). Without that I think the rules could easily be collapsed into a single one which just checks that both inputs to add/subtract is at most 25 bits