[BUG] Missing include for FreeBSD

[interkosmos]

GZDoom version

GZDoom 4.11.1

Which game are you running with GZDoom?

None

What Operating System are you using?

Other

Please describe your specific OS version

FreeBSD 13

Relevant hardware info

No response

Have you checked that no other similar issue already exists?

• I have searched and not found similar issues.

A clear and concise description of what the bug is.

In file src/common/filesystem/source/fs_findfile.cpp, the following FreeBSD-specific include is missing before the include of unistd.h:

#ifdef __FreeBSD__
#include <sys/time.h>
#endif

Steps to reproduce the behaviour.

Explain how to reproduce
1.
2.
3.

Your configuration

No response

Provide a Log

No response

[alexey-lysiuk]

What is the compilation error without this include?

[interkosmos]

Build error without the include:

[ 99%] Building CXX object src/CMakeFiles/zdoom.dir/common/filesystem/source/fs_findfile.cpp.o
In file included from /tmp/gzdoom/src/common/filesystem/source/fs_findfile.cpp:69:
In file included from /usr/include/sys/stat.h:101:
/usr/include/sys/time.h:327:5: error: member access into incomplete type 'struct timeval'
        _tv->tv_sec = _bt->sec;
           ^
/usr/include/unistd.h:487:8: note: forward declaration of 'FileSys::timeval'
struct timeval;                         /* select(2) */
       ^
In file included from /tmp/gzdoom/src/common/filesystem/source/fs_findfile.cpp:69:
In file included from /usr/include/sys/stat.h:101:
/usr/include/sys/time.h:328:5: error: member access into incomplete type 'struct timeval'
        _tv->tv_usec = __utime64_scale64_floor(
           ^
/usr/include/unistd.h:487:8: note: forward declaration of 'FileSys::timeval'
struct timeval;                         /* select(2) */
       ^
In file included from /tmp/gzdoom/src/common/filesystem/source/fs_findfile.cpp:69:
In file included from /usr/include/sys/stat.h:101:
/usr/include/sys/time.h:336:16: error: member access into incomplete type 'const struct timeval'
        _bt->sec = _tv->tv_sec;
                      ^
/usr/include/unistd.h:487:8: note: forward declaration of 'FileSys::timeval'
struct timeval;                         /* select(2) */
       ^
In file included from /tmp/gzdoom/src/common/filesystem/source/fs_findfile.cpp:69:
In file included from /usr/include/sys/stat.h:101:
/usr/include/sys/time.h:338:19: error: member access into incomplete type 'const struct timeval'
            (uint64_t)_tv->tv_usec << 32, 1ULL << 32, 1000000);
                         ^
/usr/include/unistd.h:487:8: note: forward declaration of 'FileSys::timeval'
struct timeval;                         /* select(2) */
       ^
In file included from /tmp/gzdoom/src/common/filesystem/source/fs_findfile.cpp:69:
In file included from /usr/include/sys/stat.h:101:
/usr/include/sys/time.h:359:1: error: incomplete result type 'struct timeval' in function definition
sbttotv(sbintime_t _sbt)
^
/usr/include/unistd.h:487:8: note: forward declaration of 'FileSys::timeval'
struct timeval;                         /* select(2) */
       ^
In file included from /tmp/gzdoom/src/common/filesystem/source/fs_findfile.cpp:69:
In file included from /usr/include/sys/stat.h:101:
/usr/include/sys/time.h:361:17: error: variable has incomplete type 'struct timeval'
        struct timeval _tv;
                       ^
/usr/include/unistd.h:487:8: note: forward declaration of 'FileSys::timeval'
struct timeval;                         /* select(2) */
       ^
In file included from /tmp/gzdoom/src/common/filesystem/source/fs_findfile.cpp:69:
In file included from /usr/include/sys/stat.h:101:
/usr/include/sys/time.h:369:24: error: variable has incomplete type 'struct timeval'
tvtosbt(struct timeval _tv)
                       ^
/usr/include/unistd.h:487:8: note: forward declaration of 'FileSys::timeval'
struct timeval;                         /* select(2) */
       ^
In file included from /tmp/gzdoom/src/common/filesystem/source/fs_findfile.cpp:69:
In file included from /usr/include/sys/stat.h:101:
/usr/include/sys/time.h:476:17: error: field has incomplete type 'struct timeval'
        struct  timeval it_interval;    /* timer interval */
                        ^
/usr/include/unistd.h:487:8: note: forward declaration of 'FileSys::timeval'
struct timeval;                         /* select(2) */
       ^
In file included from /tmp/gzdoom/src/common/filesystem/source/fs_findfile.cpp:69:
In file included from /usr/include/sys/stat.h:101:
/usr/include/sys/time.h:477:17: error: field has incomplete type 'struct timeval'
        struct  timeval it_value;       /* current value */
                        ^
/usr/include/unistd.h:487:8: note: forward declaration of 'FileSys::timeval'
struct timeval;                         /* select(2) */
       ^
9 errors generated.

[coelckers]

FreeBSD really needs to fix its headers.