Corrected number of script arguments in InputManager::SendKeystrokes.

In a recent refactor, this code was slightly changed, and the declaration of a Script object was expecting three arguments instead of the required four. Fixes issue SeleniumHQ#5502.
Zitrax · Apr 15, 2013 · 4eb3f7f · 4eb3f7f
1 parent a3ec202
commit 4eb3f7f
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 1 deletion.
diff --git a/cpp/IEDriver/InputManager.cpp b/cpp/IEDriver/InputManager.cpp
@@ -493,7 +493,7 @@ int InputManager::SendKeystrokes(BrowserHandle browser_wrapper, Json::Value keys
 
     CComPtr<IHTMLDocument2> doc;
     browser_wrapper->GetDocument(&doc);
-    Script script_wrapper(doc, script_source, 3);
+    Script script_wrapper(doc, script_source, 4);
 
     script_wrapper.AddNullArgument();
     script_wrapper.AddArgument(keys);

diff --git a/cpp/IEDriverServer/CHANGELOG b/cpp/IEDriverServer/CHANGELOG
@@ -9,6 +9,13 @@ available via the project downloads page. Changes in "revision" field indicate
 private releases checked into the prebuilts directory of the source tree, but
 not made generally available on the downloads page.
 
+v2.32.3.0
+=========
+ * Corrected number of script arguments in InputManager::SendKeystrokes. In a
+   recent refactor, this code was slightly changed, and the declaration of a
+   Script object was expecting three arguments instead of the required four.
+   Fixes issue #5502.
+
 v2.32.2.0
 =========
  * Corrected logic error in reading TabProcGrowth registry value. The

diff --git a/cpp/IEDriverServer/IEDriverServer.rc b/cpp/IEDriverServer/IEDriverServer.rc
diff --git a/cpp/prebuilt/Win32/Release/IEDriverServer.exe b/cpp/prebuilt/Win32/Release/IEDriverServer.exe
diff --git a/cpp/prebuilt/x64/Release/IEDriverServer.exe b/cpp/prebuilt/x64/Release/IEDriverServer.exe