Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support env var regex removal of non-utf-8 env var names. #148

Closed
jsirois opened this issue Sep 23, 2023 · 0 comments · Fixed by #149
Closed

Support env var regex removal of non-utf-8 env var names. #148

jsirois opened this issue Sep 23, 2023 · 0 comments · Fixed by #149
Assignees
@jsirois
Labels
bug Something isn't working

Comments

@jsirois
Copy link
Collaborator

jsirois commented Sep 23, 2023 •
edited
Loading

#105 fixed env var regex removals to not blow up, but it didn't actually fix them for non-utf-8 env var names: #106 (comment)
Although it appears such beasts cannot exist on Windows, they can on Unix.

We should be able to do better.
@jsirois jsirois added the bug Something isn't working label Sep 23, 2023
@jsirois jsirois self-assigned this Sep 23, 2023
@jsirois jsirois added the in progress Indicates the assignee is actively working on the item. label Sep 23, 2023
@jsirois jsirois changed the title Support env var regex removal of non-utf-8 values. Support env var regex removal of non-utf-8 env var names. Sep 23, 2023
jsirois added a commit to jsirois/jump that referenced this issue Sep 23, 2023
@jsirois
Allow regex removal of non-utf8 env var names.
b2b91ac 
Fixes a-scie#148
@jsirois jsirois mentioned this issue Sep 23, 2023
Merged
jsirois added a commit that referenced this issue Sep 23, 2023
@jsirois
Allow regex removal of non-utf8 env var names. (#149)
2f4160f 
Fixes #148
@jsirois jsirois removed the in progress Indicates the assignee is actively working on the item. label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow regex removal of non-utf8 env var names. jsirois/jump
1 participant
@jsirois