Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump bstr from 1.9.1 to 1.10.0" #231

Conversation

LeojMarco
Copy link

Reverts #228

[target.aarch64-pc-windows-msvc]
rustflags = [
"-C", "target-feature=+crt-static", # Static CRT for 64-bit ARM Windows
"-C", "link-arg=/NODEFAULTLIB:libcmt" # Avoid automatic dynamic CRT linking
]

[target.x86_64-pc-windows-msvc]
rustflags = [
"-C", "target-feature=+crt-static", # Static CRT for 64-bit x86 Windows
"-C", "link-arg=/NODEFAULTLIB:libcmt" # Avoid automatic dynamic CRT linking
]

@jsirois
Copy link
Collaborator

jsirois commented Jul 30, 2024

@LeojMarco your explanation is too terse for my knowledge base. What problem do you run into with 1.10.0?

There is no trace of the cargo config you reference in the diff:
BurntSushi/bstr@1.9.1...1.10.0

@jsirois jsirois closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants