Select a player by ID and have a query on it from PlayerDetails #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmacartney
commented
Aug 16, 2023
| @@ -9,203 +9,203 @@ import { data as f7SpritesheetData } from './spritesheets/f7'; | |||
| import { data as f8SpritesheetData } from './spritesheets/f8'; | |||
|
|
|||
| export const Descriptions = [ | |||
| { | |||
There was a problem hiding this comment.
sorry, prettier fixed some other things that got included here. We should get Martin to use Prettier :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you could select a player and only see their previous conversation.
Now, when you select a player by their ID, the details component (renamed)
will have a subscription on the player state, so as the most recent
conversation changes, it'll show the latest. Also sets the stage for more
subscriptions from there: relationships, memories, etc.