Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent an animation stop on texture change #90

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Prevent an animation stop on texture change #90

merged 1 commit into from
Aug 15, 2023

Conversation

Nicolapps
Copy link
Collaborator

We are experiencing the problem described in this Pixi React issue:

This PR fixes it by ensuring we start the animation when needed.

jamescowling
jamescowling approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@jamescowling jamescowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jamescowling jamescowling merged commit 2afe30f into main Aug 15, 2023
@ianmacartney ianmacartney deleted the nicolas/sprite-animations branch August 16, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescowling jamescowling jamescowling approved these changes

@ianmacartney ianmacartney Awaiting requested review from ianmacartney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nicolapps @jamescowling