feature: rails 4 Flash fixes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class ApplicationController < ActionController::Base; end | ||
|
|
||
| describe ApplicationController, type: :controller do | ||
|
|
There was a problem hiding this comment.
Extra empty line detected at block body beginning.
| env[KEY] = flash_hash.dup | ||
| end | ||
|
|
||
| if (!session.respond_to?(:loaded?) || session.loaded?) && # (reset_session uses {}, which doesn't implement #loaded?) |
| @app = app | ||
| end | ||
|
|
||
| def call(env) |
There was a problem hiding this comment.
Cyclomatic complexity for call is too high. [9/6]
Perceived complexity for call is too high. [9/7]
|
|
||
| def stringify_array(array) | ||
| array.map do |item| | ||
| item.kind_of?(Symbol) ? item.to_s : item |
There was a problem hiding this comment.
Prefer Object#is_a? over Object#kind_of?.
| self[:notice] = message | ||
| end | ||
|
|
||
| protected |
There was a problem hiding this comment.
Keep a blank line before and after protected.
| @flashes.each(&block) | ||
| end | ||
|
|
||
| alias :merge! :update |
There was a problem hiding this comment.
Use alias merge! update instead of alias :merge! :update.
| flash = case value | ||
| when FlashHash # Rails 3.1, 3.2 | ||
| new(value.instance_variable_get(:@flashes), value.instance_variable_get(:@used)) | ||
| when Hash # Rails 4.0 |
|
|
||
| def self.from_session_value(value) | ||
| flash = case value | ||
| when FlashHash # Rails 3.1, 3.2 |
| k = k.to_s | ||
| @flash[k] = v | ||
| @flash.discard(k) | ||
| v |
|
|
||
| # The flash provides a way to pass temporary objects between actions. Anything you place in the flash will be exposed | ||
| # to the very next action and then cleared out. This is a great way of doing notices and alerts, such as a create | ||
| # action that sets <tt>flash[:notice] = "Post successfully created"</tt> before redirecting to a display action that can |
bibendi
reviewed
Mar 20, 2018
lib/apress/utils/version.rb
Outdated
| @@ -1,5 +1,5 @@ | |||
| module Apress | |||
| module Utils | |||
| VERSION = '2.5.0'.freeze | |||
| VERSION = '2.6.0'.freeze | |||
There was a problem hiding this comment.
Горячка я считаю, в прод не вышло, а патч огромный
There was a problem hiding this comment.
ну ок, патч просто работает только в рельсах >= 4
Napolskih
force-pushed
the
rails-4-flash
branch
from
aafc43c
to
21f3cf8
Compare
|
поменял ветку 🆙 |
bibendi
approved these changes
Mar 20, 2018
|
@abak-press/apress-utils-owners |
isqad
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В рельсах 4.0/4.1 есть проблемы с флешем - пишем символы, читаем строки и тп.
rails/rails#13945
взял версию класса Flash от 4.2, фиксы:
rails/rails@a6ce984
rails/rails@a668bef
rails/rails@3c60fb4