Improve flecs benchmark integration #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple issues with how flecs is integrated with the benchmarks. Namely:
src/flecs/CMakeLists.txt
src/flecs/flecs/custom_flecs.h
.iter(...)
to avoid needing to fetchdt
for each individual entity. Also reduced the number of arguments to the functions.src/flecs/flecs/entities/EntityFactory.h
and enabled the benchmarks inbenchmark/benchmarks/flecs-entities/FlecsEntityBenchmarkSuite.cpp
HasBulkFeature
instead ofHasBulkFeatureWithOutput
or was missingHasBulkFeatureWithOutput
.std::span
usage fromsrc/flecs/flecs/systems/DataSystem.h
to match the implementation for other benchmarks.getOptionalComponentThree
which previously was only callingget_mut
which will add the component if it doesn't exist.