Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flecs benchmark integration #15

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

ZeroErrors
Copy link
Contributor

@ZeroErrors ZeroErrors commented Jan 6, 2024

Fixes a couple issues with how flecs is integrated with the benchmarks. Namely:

  • Updated options used in src/flecs/CMakeLists.txt
  • Disabled timers and other unneeded modules in src/flecs/flecs/custom_flecs.h
  • Modified flecs systems to take advantage of .iter(...) to avoid needing to fetch dt for each individual entity. Also reduced the number of arguments to the functions.
  • Implemented bulk entity operations in src/flecs/flecs/entities/EntityFactory.h and enabled the benchmarks in benchmark/benchmarks/flecs-entities/FlecsEntityBenchmarkSuite.cpp
  • Fixed a few cases where either incorrectly used HasBulkFeature instead of HasBulkFeatureWithOutput or was missing HasBulkFeatureWithOutput.
  • Removed std::span usage from src/flecs/flecs/systems/DataSystem.h to match the implementation for other benchmarks.
  • Fixed implementation of getOptionalComponentThree which previously was only calling get_mut which will add the component if it doesn't exist.
  • Removed C++23 feature usage. Fixes C++23 features used but build target is C++20 #14

@abeimler abeimler merged commit 0cc2613 into abeimler:master Jan 6, 2024
abeimler added a commit that referenced this pull request Jan 6, 2024
@ZeroErrors ZeroErrors deleted the improve-flecs-benchmark branch January 7, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++23 features used but build target is C++20
2 participants