Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retry on upcoming assertions #340

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Fix retry on upcoming assertions #340

merged 2 commits into from
Jun 17, 2022

Conversation

daniele-pini
Copy link
Contributor

Summary

This PR fixes retries for upcoming assertions on commands react and getReact. Closes #339.

@daniele-pini
Copy link
Contributor Author

@abhinaba-ghosh, was there a specific reason to add the then() at the end? I'm wondering because it doesn't seem to have a purpose, but maybe I'm wrong?

@abhinaba-ghosh
Copy link
Owner

Hi @daniele-pini thanks for raising this PR. This makes sense.

@abhinaba-ghosh abhinaba-ghosh merged commit eab0da7 into abhinaba-ghosh:master Jun 17, 2022
@daniele-pini daniele-pini deleted the fix_retry_upcoming_assertions branch June 17, 2022 08:29
@abhinaba-ghosh
Copy link
Owner

This should be available in version 2.3.19

@daniele-pini
Copy link
Contributor Author

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinaba-ghosh abhinaba-ghosh abhinaba-ghosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functions react() and getReact() don't retry upcoming assertions
2 participants
@daniele-pini @abhinaba-ghosh