Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loan Repayment Prediction Project #704

Merged
merged 5 commits into from
Jul 14, 2024

Conversation

aviralgarg05
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: Loan Repayment Prediction Project #692

  • Info about the related issue (Aim of the project) : Predict Repayment of Loan
  • Name: Aviral Garg
  • Email ID for further communication: gargaviral99@gmail.com
  • GitHub ID: aviralgarg05
  • Idenitfy yourself: SSOC Contributor

Closes: #issue number that will be closed through this PR
#692

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made
ML Algorithms to predict the repayment with greate accuracy

Type of change ☑️

NA
What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested- Tested using the previous data
Describe how have you verified the changes made- Using other models based on credit score

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Jul 9, 2024

Our team will soon review your PR. Thanks @aviralgarg05 :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the project structure and update the files.
@aviralgarg05

@abhisheks008 abhisheks008 linked an issue Jul 12, 2024 that may be closed by this pull request
@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Jul 12, 2024
@aviralgarg05
Copy link
Contributor Author

Please follow the project structure and update the files. @aviralgarg05

What changes in the project structure?

@abhisheks008
Copy link
Owner

Project folder should be like this,

Loan Re-payment Prediction
|- Dataset
   |- dataset.csv
|- Images
   |- img1.png
   |- img2.png
   |- img3.png
   .  .
   .  .
   .  .
   |- img10.png
|- Model
   |- loan_repayment_prediction.ipynb
|- README.md
|- requirements.txt

@aviralgarg05
Copy link
Contributor Author

Kindly check for all the required changes that are done.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Create a folder as Images and put the all the project generated images inside that folder.
  2. The name of the project folder should be same as the issue name.
  3. Inside the README, it's better to create a table and put the all the accuracy checking parameters of the deployed models so that others can understand the logic of selecting the best fitted model among all the deployed models.

@aviralgarg05

@aviralgarg05 aviralgarg05 changed the title Loan Payment Prediction Project Loan Repayment Prediction Project Jul 14, 2024
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aviralgarg05 looks good to me. Approved ✅

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jul 14, 2024
@abhisheks008 abhisheks008 merged commit b90eead into abhisheks008:main Jul 14, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 Points Added 🎉 This issue's points has been added to the leaderboard. SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loan Repayment Prediction
2 participants