Remove previous query param deleting warning (vercel#37740)

aboqasem · Jun 18, 2022 · 12e098d · 12e098d
1 parent 6c2aa71
commit 12e098d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 39 deletions.
diff --git a/packages/next/server/next-server.ts b/packages/next/server/next-server.ts
@@ -1378,12 +1378,6 @@ export default class NextNodeServer extends BaseServer {
           const parsedDestination = parseUrl(rewritePath)
           const newUrl = parsedDestination.pathname
 
-          // TODO: remove after next minor version current `v12.0.9`
-          this.warnIfQueryParametersWereDeleted(
-            parsedUrl.query,
-            parsedDestination.query
-          )
-
           if (
             parsedDestination.protocol &&
             (parsedDestination.port
@@ -1449,26 +1443,6 @@ export default class NextNodeServer extends BaseServer {
     return require(join(this.distDir, ROUTES_MANIFEST))
   }
 
-  // TODO: remove after next minor version current `v12.0.9`
-  private warnIfQueryParametersWereDeleted(
-    incoming: ParsedUrlQuery,
-    rewritten: ParsedUrlQuery
-  ): void {
-    const incomingQuery = urlQueryToSearchParams(incoming)
-    const rewrittenQuery = urlQueryToSearchParams(rewritten)
-
-    const missingKeys = [...incomingQuery.keys()].filter((key) => {
-      return !rewrittenQuery.has(key)
-    })
-
-    if (missingKeys.length > 0) {
-      Log.warn(
-        `Query params are no longer automatically merged for rewrites in middleware, see more info here: https://nextjs.org/docs/messages/deleting-query-params-in-middlewares`
-      )
-      this.warnIfQueryParametersWereDeleted = () => {}
-    }
-  }
-
   private async runEdgeFunctionApiEndpoint(params: {
     req: NodeNextRequest
     res: NodeNextResponse

diff --git a/test/e2e/middleware-rewrites/test/index.test.ts b/test/e2e/middleware-rewrites/test/index.test.ts
@@ -169,19 +169,6 @@ describe('Middleware Rewrite', () => {
       }, 'success')
     })
 
-    if (!(global as any).isNextDeploy) {
-      // runtime logs aren't currently available for deploy test
-      it(`warns about a query param deleted`, async () => {
-        await fetchViaHTTP(next.url, `/clear-query-params`, {
-          a: '1',
-          allowed: 'kept',
-        })
-        expect(next.cliOutput).toContain(
-          'Query params are no longer automatically merged for rewrites in middleware'
-        )
-      })
-    }
-
     it('should allow to opt-out prefetch caching', async () => {
       const browser = await webdriver(next.url, '/')
       await browser.addCookie({ name: 'about-bypass', value: '1' })