Make cron job parameter configurable #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalfertheiner
commented
Aug 1, 2023
defaults/main.yml
Outdated
| @@ -2,6 +2,7 @@ | |||
| postgresql_backup: | |||
| enabled: false | |||
| directory: '' | |||
| cron: '30 03 * * *' | |||
There was a problem hiding this comment.
@alexlanz
do I need the quotes here?
There was a problem hiding this comment.
Suggested change
| cron: '30 03 * * *' | |
| time: '30 03 * * *' |
You don't need the quotes, but is also no problem if you leave them.
What do you think about giving the property a more specific name?
There was a problem hiding this comment.
I think cron is actually more explicit then time.
For example in Spring boot you can schedule jobs and they also name it cron:
@Scheduled(cron = "30 03 * * *")
mmalfertheiner
commented
Aug 1, 2023
tasks/main.yml
Outdated
| ansible.builtin.copy: | ||
| src: files/postgres | ||
| ansible.builtin.template: | ||
| src: templates/postgres.j2 | ||
| dest: /etc/cron.d/postgres |
There was a problem hiding this comment.
@alexlanz should we give the cron job a more explicit name? postgres-backup?
alexlanz
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.