Make sure namespace packages obtained via import finder handle later additions to path #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the PEP 420, namespace packages need to gracefully handle later additions to path.
See https://discuss.python.org/t/pep-660-and-setuptools/14855/15
Summary of changes
PathEntryFinder
+ an arbitrary placeholder entry onsys.path
to forcePathFinder
to create a namespace spec._NamespacePath
and_NamespaceLoader
are private classes (or just documented for comparison purposes), there is no other way to implement this behaviour directly1.Closes
Pull Request Checklist
changelog.d/
.(See documentation for details)
Footnotes
Reimplementing
_NamespacePath
+ a custom logic to maintain namespace portions don't have a corresponding path entry also seems to have the same end result. ↩