Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ABSL_DLL for a few functions #1002

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Aug 16, 2021

The throw_bad_optional_access and ThrowBadVariantAccess are used in a few inlined functions and should have the ABSL_DLL prefix, otherwise linking with absl.dll will fail with errors like:

error LNK2019: unresolved external symbol "void __cdecl absl::
optional_internal::throw_bad_optional_access(void)" (?throw_bad_optional_access@opt
ional_internal@absl@@YAXXZ) referenced in function "public: class base::TimeDelta &
 __cdecl absl::optional<class base::TimeDelta>::value(void)& " (?value@?$optional@V
TimeDelta@base@@@absl@@QEGAAAEAVTimeDelta@base@@XZ)\r\n'

@google-cla google-cla bot added the cla: yes label Aug 16, 2021
@derekmauro derekmauro self-assigned this Aug 16, 2021
@derekmauro
Copy link
Member

Thank you. This should be merged soon.

@derekmauro derekmauro merged commit f9d3bc9 into abseil:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants