Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw specific GraphQL errors #404

Closed
lorensr opened this issue Jul 23, 2018 · 0 comments · Fixed by #1258
Closed

Throw specific GraphQL errors #404

lorensr opened this issue Jul 23, 2018 · 0 comments · Fixed by #1258
Labels
1.0 enhancement low hanging fruit
Milestone
1.0

Comments

@lorensr
Copy link
Contributor

lorensr commented Jul 23, 2018

I think this type of error should not be classified as an internal server error:

image

It should have code: "UNAUTHENTICATED", which you get by throw new AuthenticationError(). There's also ForbiddenError, UserInputError and custom error types:

https://www.apollographql.com/docs/apollo-server/features/errors.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 enhancement low hanging fruit
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

feat: release 1.0 accounts-js/accounts
3 participants
@lorensr @TimMikeladze @darkbasic