Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release 1.0 #1258

Merged
merged 3 commits into from
Jan 8, 2024
Merged

feat: release 1.0 #1258

merged 3 commits into from
Jan 8, 2024

Conversation

darkbasic
Copy link
Member

@darkbasic darkbasic commented Oct 22, 2023

Closes #1248
Closes #1247
Closes #1244
Closes #1226
Closes #1156
Closes #1142
Closes #1034
Closes #816
Closes #768
Closes #632
Closes #627
Closes #607
Closes #483
Closes #466
Closes #404

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2023

🦋 Changeset detected

Latest commit: d74c0d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@accounts/mikro-orm Major
@accounts/typeorm Major
@accounts/express-session Major
@accounts/magic-link Major
@accounts/password Major
@accounts/server Major
@accounts/rest-client Major
@accounts/module-password Major
@accounts/module-core Major
@accounts/module-magic-link Major
@accounts/module-mikro-orm Major
@accounts/module-mongo Major
@accounts/module-typeorm Major
@accounts/apollo-link Major
@accounts/client Major
@accounts/client-magic-link Major
@accounts/client-password Major
@accounts/mongo Major
@accounts/mongo-magic-link Major
@accounts/mongo-password Major
@accounts/mongo-sessions Major
@accounts/redis Major
@accounts/database-tests Major
@accounts/error Major
@accounts/graphql-client Major
@accounts/oauth Major
@accounts/oauth-instagram Major
@accounts/oauth-twitter Major
@accounts/rest-express Major
@accounts/two-factor Major
@accounts/types Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2023

💻 Website Preview

The latest changes are available as preview in: https://33a4e63c.accounts-js.pages.dev

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (760a59b) 92.59% compared to head (3b08baf) 92.59%.
Report is 2 commits behind head on master.

❗ Current head 3b08baf differs from pull request most recent head d74c0d3. Consider uploading reports for the commit d74c0d3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1258   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files         117      117           
  Lines        2527     2527           
  Branches      569      569           
=======================================
  Hits         2340     2340           
  Misses        173      173           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@accounts/module-core 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/module-magic-link 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/module-mikro-orm 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/module-mongo 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/module-password 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/module-typeorm 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/apollo-link 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/client 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/client-magic-link 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/client-password 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/mikro-orm 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/mongo 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/mongo-magic-link 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/mongo-password 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/mongo-sessions 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/redis 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/typeorm 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/error 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/express-session 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/graphql-client 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/magic-link 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/oauth 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/oauth-instagram 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/oauth-twitter 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/password 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/rest-client 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/rest-express 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/server 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/two-factor 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎
@accounts/types 1.0.0-alpha-20240108082143-d74c0d3658792ccbd34fa5aa1573654370caaaf0 npm ↗︎ unpkg ↗︎

@mrcleanandfresh
Copy link
Contributor

mrcleanandfresh commented Oct 25, 2023

@darkbasic I was getting this up-and-running, using the documentation, and trying to take the most naive approach as possible, by using a plain JavaScript server (using server.js). When I run node server.js I'm getting an error about reflect-metadata:

node:internal/process/esm_loader:97
    internalBinding('errors').triggerUncaughtException(
                              ^
reflect-metadata shim is required when using class decorators

I wanted to touch base really fast, before adding it to the list I'm keeping for my PR on Documentation changes.

Should we encourage the use of TypeScript with the experimental decorators flag? Or am I just not configuring something, correctly?

What I have done so far is run:

yarn add @accounts/module-core@1.0.0-alpha-20231022085748-0910b9e1 graphql-modules @accounts/server@1.0.0-alpha-20231022085748-0910b9e1 @accounts/module-mongo@1.0.0-alpha-20231022085748-0910b9e1 @accounts/mongo@1.0.0-alpha-20231022085748-0910b9e1 @accounts/module-password@1.0.0-alpha-20231022085748-0910b9e1 @accounts/password@1.0.0-alpha-20231022085748-0910b9e1

Then pasted your example code from getting started into server.js and issued node server.js.

@mrcleanandfresh
Copy link
Contributor

Okay, looks like your example needed:

import 'reflect-metadata';

At the top. I'll put that on my list.

@darkbasic
Copy link
Member Author

Yes you need reflect-metadata. If something from the documentation doesn't work I suggest you to have a look at the examples folder because these get tested much more often.
Docs need to be updated to reflect some of the latest changes.

@mrcleanandfresh
Copy link
Contributor

Yes you need reflect-metadata. If something from the documentation doesn't work I suggest you to have a look at the examples folder because these get tested much more often. Docs need to be updated to reflect some of the latest changes.

Yeah, my plan is to take the documentation for a test drive and see if there are any holes in it for folks getting up and running. I was able to get up-and-running in about 30-45 minutes after some troubleshooting. So I took note of those missing elements. Most folks are going to want as little friction as possible while on-boarding. So I am keeping a list of changes I want to make to the documentation.

Good to know about the examples folder! Thanks.

Maybe we should leave comments in the open issues about the new release. I saw a very serious bug with a failed OAuth attempt that returned the first record from the users database. That's a pretty serious bug, but may be a non-issue after the re-factor? It'd be good to have the issue authors go back through after the official release to see if they are still experiencing their problems. Thoughts?

@darkbasic
Copy link
Member Author

Maybe we should leave comments in the open issues about the new release. I saw a very serious bug with a failed OAuth attempt that returned the first record from the users database. That's a pretty serious bug, but may be a non-issue after the re-factor?

Yes leave comments in the respective issues if you find anything that you can still reproduce.
I saw the OAuth one and I honestly didn't check it yet, but that's surely one that needs to be addressed before the stable release.

@darkbasic darkbasic merged commit da13d0d into master Jan 8, 2024
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the release1.0 branch January 8, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment