Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@accounts/mongo] Use mongodb as peer dependency #466

Closed
aslafy-z opened this issue Sep 27, 2018 · 0 comments · Fixed by #1258
Closed

[@accounts/mongo] Use mongodb as peer dependency #466

aslafy-z opened this issue Sep 27, 2018 · 0 comments · Fixed by #1258

Comments

@aslafy-z
Copy link
Contributor

I seen that you were trying to keep compatibility with old mongodb driver versions but it looks that the mongodb dependency is locked to the latest version.
I think it should switch to a peer-dependency in order to let the user choose what version to use.

https://github.com/accounts-js/accounts/blob/master/packages/database-mongo/README.md#usage
https://github.com/accounts-js/accounts/blob/master/packages/database-mongo/package.json#L48
https://docs.npmjs.com/files/package.json#peerdependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants