Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManyCubes example scene, Instance rate vertex attribute support #148

Merged
merged 3 commits into from
Jun 1, 2021
Merged

ManyCubes example scene, Instance rate vertex attribute support #148

merged 3 commits into from
Jun 1, 2021

Conversation

DavidVonDerau
Copy link
Collaborator

@DavidVonDerau DavidVonDerau commented May 21, 2021 •
edited
Loading

Closes #129.

  • Add ManyCubes scene.
  • Support disabling depth prepass.
  • Use instance rate vertex attribute for model matrix in mesh / depth shaders.

@DavidVonDerau DavidVonDerau marked this pull request as draft May 21, 2021 04:58
@DavidVonDerau DavidVonDerau mentioned this pull request May 21, 2021
Closed
@DavidVonDerau DavidVonDerau changed the title WIP: ManyCubes example + MeshFeature perf WIP: ManyCubes example scene, dynamic Mesh materials, Instance rate vertex attribute support May 21, 2021
aclysma
aclysma reviewed May 26, 2021
View reviewed changes
Copy link
Owner

@aclysma aclysma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I apparently forgot to hit the "submit review" button so these comments were just sitting..sorry about that!

rafx-framework/src/resources/descriptor_sets/mod.rs Show resolved Hide resolved
demo/src/features/mesh/jobs/write.rs Show resolved Hide resolved
demo/src/features/mesh/jobs/prepare.rs Outdated Show resolved Hide resolved
rafx-framework/src/visibility/visibility_object_arc.rs Outdated Show resolved Hide resolved
rafx-shader-processor/src/reflect.rs Show resolved Hide resolved
demo/src/features/mesh/jobs/prepare.rs Outdated Show resolved Hide resolved
@DavidVonDerau DavidVonDerau changed the title WIP: ManyCubes example scene, dynamic Mesh materials, Instance rate vertex attribute support WIP: ManyCubes example scene, Instance rate vertex attribute support May 31, 2021
@DavidVonDerau DavidVonDerau force-pushed the dvd/manycubes branch 4 times, most recently from 0371bc7 to 93a287e Compare May 31, 2021 17:57
@DavidVonDerau DavidVonDerau marked this pull request as ready for review May 31, 2021 17:59
@DavidVonDerau DavidVonDerau changed the title WIP: ManyCubes example scene, Instance rate vertex attribute support ManyCubes example scene, Instance rate vertex attribute support May 31, 2021
@DavidVonDerau
Copy link
Collaborator Author

I removed the code associated with dynamic mesh materials.

@aclysma aclysma merged commit 2afe8fb into aclysma:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclysma aclysma aclysma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPU instancing support in the framework & demo features
2 participants
@DavidVonDerau @aclysma